dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land.
In D84870#2183096 <https://reviews.llvm.org/D84870#2183096>, @akhuang wrote: > remove change to add class types to retained types list, > > also fix the test case to be a struct that previously didn't > get complete debug info. Ah, I see what you mean. Perhaps the implementation can/should be changed to trigger on source uses of the ctor rather than only DWARF uses? Though I suppose that'd have problems with the ctor being used in unused code. (like the "requires complete type" optimization does - the type can be required to be complete in unused code) Sounds good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84870/new/ https://reviews.llvm.org/D84870 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
