vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land.
Thanks, looks good to me with a small test addition. ================ Comment at: clang/test/CodeGen/builtins-overflow.c:123 + // CHECK: br i1 [[C2]] + int r; + if (__builtin_mul_overflow(x, y, &r)) ---------------- vsk wrote: > Could you add a test for the volatile result case? I think this is still missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84405/new/ https://reviews.llvm.org/D84405 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
