ymandel marked an inline comment as done.
ymandel added inline comments.
================
Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:125
+/// not bound, then no edits are produced.
+inline EditGenerator ifBound(std::string ID, ASTEdit TrueEdit) {
+ return ifBound(std::move(ID), edit(std::move(TrueEdit)), noEdits());
----------------
asoffer wrote:
> I don't know about LLVM style preferences here, but a default argument to the
> example above seems reasonable too.
I'd like that, but don't see how to get the types to work out, "noEdits" is a
generator, but FalseEdit branch is an `ASTEdit`. did you have something in mind?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84310/new/
https://reviews.llvm.org/D84310
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
