balazske marked an inline comment as done.
balazske added inline comments.
================
Comment at: clang/test/Analysis/malloc-plist.c:137-139
if (y)
- y++;
-}//expected-warning{{Potential leak}}
+ y++; //expected-warning{{Potential leak}}
+}
----------------
NoQ wrote:
> This sounds like an expected change: we're now displaying the same report on
> a different path. Except it's the longer path rather than the shorter path,
> so it still looks suspicious.
This location may be wrong but it is then another problem. The important thing
is that after this patch the same location is used for a warning in
`text-minimal` mode as it is in `text` mode. Without the patch in
`text-minimal` mode a different location is used for this warning, the one at
the end of the function. But still in `text` mode (without the patch) the
location at `y++` is shown. (The warning in function `function_with_leak4` in
the same test is already at a similar location, not at the end of function.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83961/new/
https://reviews.llvm.org/D83961
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
