wanders added a comment. In D84090#2162389 <https://reviews.llvm.org/D84090#2162389>, @MyDeveloperDay wrote:
> 2. then I can do `git clang-format`, this will fix up any files in the diff > that need formatting (you'll need to git add them again if they have) (I use https://github.com/kimgr/git-format ) just need to remember to run it... But created a "prepare-patch" script now so as long as I remember to run that. > > > 3. I then check the documentation builds with `/usr/bin/sphinx-build -n > ./docs ./html` (if the review contains rst files) Great tip! Thanks > > > 4. then I do `git diff --cached -U999999 > patch_to_submitt.diff` > 5. I check the patch to ensure I'm not changing the mode of the files with > `grep -A0 -B2 "new mode" patch_to_submitt.diff` > 6. and this is the patch_tosubmitt.diff I upload to the review > > These steps try to reduce the number of review fails I get based on > clang-format issues (all of this is scripted so making a patch is repeatable, > quick and easy and all based off whats in my staged area) Thanks for assistance and review. And sorry about the extra noise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84090/new/ https://reviews.llvm.org/D84090 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
