aaron.ballman added a comment.
I like the way the code is shaping up with the slightly altered design, nice!
================
Comment at: clang/lib/AST/ASTContext.cpp:1872
+unsigned getSveVectorWidth(const Type *T) {
+ // Get the vector size from the 'arm_sve_vector_bits' attribute via the
----------------
Should declare the method as `static`.
================
Comment at: clang/lib/AST/ASTContext.cpp:1887
+
+unsigned getSvePredWidth(const Type *T) { return getSveVectorWidth(T) / 8; }
+
----------------
Should this be dividing by the number of bits in a char for the target as
opposed to hard-coding to 8?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83551/new/
https://reviews.llvm.org/D83551
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
