sammccall added inline comments.
================ Comment at: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp:329 + )cpp", + // Argument lists. + R"cpp( ---------------- kbobyrev wrote: > sammccall wrote: > > missing lambdas, blocks, objc methods. > > cover bodies in the same tests? > > capture lists of lambdas? > What kind of blocks? Do you mean statement groups? What do you mean by "cover > bodies in the same tests"? What kind of bodies? > What kind of blocks? Parallel-universe lambdas https://clang.llvm.org/doxygen/classclang_1_1BlockDecl.html#details (Commonly used in the apple world I think, though it's not actually an extension to objc but rather c) > What do you mean by "cover bodies in the same tests"? You have to go through the different ways to write functions here, I was just suggesting making sure they are definitions so you can test their body ranges too... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83914/new/ https://reviews.llvm.org/D83914 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
