jdoerfert added a comment. In D81031#2159895 <https://reviews.llvm.org/D81031#2159895>, @jhuber6 wrote:
> Fixing errors caused by unused attribute sets. Adding missing attributes to > barrier_codegen.cpp. > > Should I go ahead and commit this considering the previous was temporarily > reverted? Or should I just wait a bit to see if it fails testing again. If you only did minor modifications and no major problem showed up, the previous LGTM still stands. You should (always) run a full make check-all locally (or better on a server) to verify no other issues are known. FWIW, it happens that we break bots and patches get reverted. That is not great but also not too bad. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81031/new/ https://reviews.llvm.org/D81031 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
