aaron.ballman added a comment.

In D83174#2155143 <https://reviews.llvm.org/D83174#2155143>, @gargvaibhav64 
wrote:

> The tests weren't failing for me. So, we are possibly missing test coverage. 
> I have made the change now.


Thanks for making the change.

> Also, I would like to add that the current test present in this diff does not 
> fail in the existing system but it was the best I and Vassil could come up 
> with to replicate our problem.

Is there a way to run something like creduce to come up with a test case that 
does replicate the issue? I'd like to ensure we have a test case that fails 
without the patch applied so that we can be sure we don't regress the behavior.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83174/new/

https://reviews.llvm.org/D83174



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to