ABataev added inline comments.
================ Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7948-7949 + MapFlagsArrayTy &Types, + const llvm::DenseSet<const ValueDecl *> &SkipVarSet = + llvm::DenseSet<const ValueDecl *>()) const { // We have to process the component lists that relate with the same ---------------- Use `llvm::DenseSet<CanonicalDeclPtr<const ValueDecl>> &SkipVarSet`. ================ Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9439 llvm::DenseMap<llvm::Value *, llvm::Value *> LambdaPointers; + llvm::DenseSet<const ValueDecl *> MappedVarSet; ---------------- `llvm::DenseSet<CanonicalDeclPtr<const ValueDecl>> MappedVarSet;` ================ Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9469 + if (!CI->capturesThis()) + MappedVarSet.insert(CI->getCapturedVar()->getCanonicalDecl()); + else ---------------- No need to get canonical decl here for `llvm::DenseSet<CanonicalDeclPtr<const ValueDecl>>` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83922/new/ https://reviews.llvm.org/D83922 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits