sammccall added a comment. In D83508#2155174 <https://reviews.llvm.org/D83508#2155174>, @ArcsinX wrote:
> In D83508#2143625 <https://reviews.llvm.org/D83508#2143625>, @sammccall wrote: > > > Your test cases show two problems with this strategy: > > > > - we ignore comments and semicolons, but not preprocessor directives (or > > disabled preprocessor regions). I think we can fix this by asking > > TokenBuffer if a spelled token is part of a region that maps to no > > (PP-)expanded tokens. > > > I have tried this locally. seems it breaks SelectionTest.IncludedFile test. Yeah that makes sense, I guess it just says nothing is selected in that case? Selecting the `while` is probably marginally better for that exact case, but selecting nothing seems fine to me. @kadircet any concerns with that "regression"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83508/new/ https://reviews.llvm.org/D83508 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
