rsmith added inline comments. ================ Comment at: docs/ClassScope.rst:2 @@ +1,3 @@ +=========== +Class Scope +=========== ---------------- Can you use some word other than "scope" here? "Class scope" is already a term of art in C++, meaning something completely different. I think what you're referring to is exactly the visibility of the class (in the ELF sense).
================ Comment at: docs/ClassScope.rst:13 @@ +12,3 @@ +to a single linkage unit (i.e. the executable or DSO). It is effectively an +ODR violation to declare classes with linkage-unit scope in multiple linkage +units. Classes with global scope may be defined in multiple linkage units, ---------------- classes -> a class Otherwise this reads like you're saying at most one linkage unit per program can declare classes with linkage-unit scope. ================ Comment at: docs/ClassScope.rst:14 @@ +13,3 @@ +ODR violation to declare classes with linkage-unit scope in multiple linkage +units. Classes with global scope may be defined in multiple linkage units, +but the tradeoff is that the virtual function call optimization and control ---------------- Classes -> A class http://reviews.llvm.org/D18635 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
