sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
Nice, thanks! ================ Comment at: clang-tools-extra/clangd/Protocol.h:1523 + unsigned startLine = 0; + llvm::Optional<unsigned> startCharacter; + unsigned endLine = 0; ---------------- for outgoing fields that are optional in the protocol but we always set, we tend to omit `Optional`. The protocol is worded in a way that suggests servers may continue to set the character fields even for line-oriented editors, and I think we should do this, dropping `Optional` here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82436/new/ https://reviews.llvm.org/D82436 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
