dblaikie added a comment.
In D83648#2146472 <https://reviews.llvm.org/D83648#2146472>, @pzheng wrote:
> Actually, this patch won't change --help because it just reduced some
> duplication by extracting the common part (" the integrated assembler") of
> the help message into the "help" of "OptOutFFlag". Sorry for the confusion.
>
> The real fix here is to restore "integrated_as" as a DriverOption. Without
> this, when we have -fintegrated-as on a link line, it will be passed to the
> linker and cause the linker to fail because it is not a valid linker flag.
Sounds like that could be tested with a driver test (using -### to see what the
linker command would be and validating that it doesn't include -fintegrated-as?
- see other similar tests in clang/test/Driver, I think)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83648/new/
https://reviews.llvm.org/D83648
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
