arsenm marked 2 inline comments as done. arsenm added inline comments.
================ Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:288 + if (!IsNullCPU) { + // Default to wave32 if available, or wave64 if not + if (Features.count("wavefrontsize32") == 0 && ---------------- sameerds wrote: > So the implication here is that wave32 is the preferred choice on newer > architectures, and hence the default when available? Yes, this has always been the case ================ Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:293 + "wavefrontsize32" : "wavefrontsize64"; + Features.insert(std::make_pair(DefaultWaveSizeFeature, true)); + } ---------------- yaxunl wrote: > what's the default wave front size in backend for gfx10* before this change? It's always been wave32 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82087/new/ https://reviews.llvm.org/D82087 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits