gribozavr2 added inline comments.
================ Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:634 + // `SourceLocation`s. As a result one of these nodes has a valid + // `SourceLocation` that doesn't point to a token. + // ---------------- eduucaldas wrote: > gribozavr2 wrote: > > "The semantic AST node for has child nodes that reference two source > > locations, the location of the beginning of the token (`1`), and the > > location of the beginning of the UDL suffix (`_`). The UDL suffix location > > does not point to the beginning of a token, so we can't represent the UDL > > suffix as a separate syntax tree node." > I changed your comment slightly, WDYT LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://reviews.llvm.org/D82157 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
