shafik added inline comments.
================
Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:2197
// least as many of them as possible).
return RD->isTrivial() && RD->isCXX11StandardLayout();
}
----------------
teemperor wrote:
> See here for the POD check that we might get wrong.
I don't believe we are getting this wrong or at least not in the original
problem. Going back and checking it we seem to be getting this right.
================
Comment at: lldb/test/Shell/Expr/Inputs/layout.cpp:40
+ D2 d2;
+ D3 d3;
+
----------------
teemperor wrote:
> Do we actually need these locals in addition to the globals?
I left them in by accident.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83008/new/
https://reviews.llvm.org/D83008
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
