clementval added a comment.
In D82659#2136909 <https://reviews.llvm.org/D82659#2136909>, @michele.scandale
wrote:
> Why `omp_gen` is now a dependency of `clang-tablegen-targets` rather than
> being in the `LLVM_COMMON_DEPENDS` list like `clang-tablegen-targets`?
>
> Moreover I've noticed that with the recent changes where `omp_gen` has been
> added as a dependency in several libraries, this was done unconditionally
> breaking the Clang standalone build.
> For the same issue `intrinsics_gen` is added only if `CLANG_BUILT_STANDALONE
> ` is false.
>
> At this point I think that something like:
>
> # All targets below may depend on all tablegen'd files.
> get_property(CLANG_TABLEGEN_TARGETS GLOBAL PROPERTY CLANG_TABLEGEN_TARGETS)
> add_custom_target(clang-tablegen-targets DEPENDS ${CLANG_TABLEGEN_TARGETS})
> set_target_properties(clang-tablegen-targets PROPERTIES FOLDER "Misc")
> list(APPEND LLVM_COMMON_DEPENDS clang-tablegen-targets)
> if(NOT CLANG_BUILT_STANDALONE)
> list(APPEND LLVM_COMMON_DEPENDS omg_gen)
> endif()
>
>
> would fix all the issues, and it would allow removing the explicit
> dependencies added to each clang library.
>
> Is there any issue with my reasoning?
Looks good but just one question ... When clang is built as standalone it does
not build the OpenMP part inside Clang? I haven't seen any code to avoid
compiling the OpenMP parsing and semantic checking inside clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82659/new/
https://reviews.llvm.org/D82659
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
