sammccall marked 5 inline comments as done. sammccall added inline comments.
================ Comment at: .gitignore:57 +# clangd index. (".clangd" is a config file now, thus trailing slash) +.clangd/ +.cache ---------------- kadircet wrote: > why do we still need this ? i thought index (and other caches) would reside > in `.cache` ? Otherwise we're going to end up with indexes from old versions of clangd checked in :-( ================ Comment at: .gitignore:58 +.clangd/ +.cache # static analyzer regression testing project files ---------------- hokein wrote: > I'm afraid that many projects have to update their `.gitignore`, but this is > a tradeoff... Yeah. This is a consequence of naming the config file `.clangd`, which I think is pretty desirable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83099/new/ https://reviews.llvm.org/D83099 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits