kadircet accepted this revision.
kadircet marked an inline comment as done.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks for doing this!
================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:184
+ TFS, CDB,
BackgroundIndexStorage::createDiskBackedStorageFactory(
[&CDB](llvm::StringRef File) { return CDB.getProjectInfo(File); }),
----------------
I think we should move storage factory into options too ?
================
Comment at: clang-tools-extra/clangd/index/Background.h:127
// all commands in a compilation database. Indexing happens in the background.
-// FIXME: it should also persist its state on disk for fast start.
// FIXME: it should watch for changes to files on disk.
----------------
🎉
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83157/new/
https://reviews.llvm.org/D83157
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
