baloghadamsoftware added inline comments.
================ Comment at: clang/include/clang/StaticAnalyzer/Core/CheckerRegistryData.h:216 + /// This output is not intended to be machine-parseable. + void printCheckerWithDescList(const AnalyzerOptions &AnOpts, raw_ostream &Out, + size_t MaxNameChars = 30) const; ---------------- Why not store `AnOpts` in `CheckerRegistryData`? It would save the need to pass it to every function separately. ================ Comment at: clang/lib/StaticAnalyzer/Core/CheckerRegistryData.cpp:166 +void CheckerRegistryData::printEnabledCheckerList(const AnalyzerOptions &AnOpts, + raw_ostream &Out) const { + for (const auto *i : EnabledCheckers) ---------------- Why do we need the new `AnOpts` parameter here? It does not seem to be used at all. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82585/new/ https://reviews.llvm.org/D82585 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits