baloghadamsoftware marked an inline comment as done.

================
Comment at: clang-tidy/misc/MiscTidyModule.cpp:54
@@ -55,1 +53,3 @@
+    CheckFactories.registerCheck<AssignOperatorCheck>(
+        "misc-assign-operator");
     CheckFactories.registerCheck<BoolPointerImplicitConversionCheck>(
----------------
alexfh wrote:
> Check names usually contain hints at the class of problems they detect (e.g. 
> "misc-inaccurate-erase" or "misc-macro-repeated-side-effects"), while 
> `misc-assign-operator` doesn't serve this purpose and is overall a bit too 
> vague (there's nothing wrong with assign operators per se).
> 
> I wonder whether a more specific name would be more helpful to the users. I'm 
> thinking of something like `misc-assign-operator-conventions`. WDYT?
I have no better idea either. Should I rename it or let us wait for other 
potential reviewers proposing another name?


http://reviews.llvm.org/D18265



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to