dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed.
> Plus replacing a few std::map<string,...> with llvm::StringMap That doesn't sound NFC since it changes ordering semantics. It seems to me like it should be done separately from the rest of the patch. It would be nice to split up the rest of the patch too; besides simplifying review, if you leave the `#include` removals for a final commit it'll be easier to revert if/where necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82661/new/ https://reviews.llvm.org/D82661 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
