kadircet added inline comments.
================
Comment at: clang/include/clang/Basic/SourceManager.h:1649
const SrcMgr::SLocEntry &getLocalSLocEntry(unsigned Index,
bool *Invalid = nullptr) const {
assert(Index < LocalSLocEntryTable.size() && "Invalid index");
----------------
kadircet wrote:
> i think we should drop Invalid from the signature completely if we are going
> for this.
>
> I've sent out D82532 to get rid of the libclang dependency on this, after it
> lands this should be possible to clear.
landed that patch please rebase and get rid of this parameter completely. Also
please add a comment to `getSLocEntryByID` saying that `Invalid won't be
modified for local sloc entries`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82498/new/
https://reviews.llvm.org/D82498
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
