nickdesaulniers added inline comments.
================
Comment at: clang/lib/Basic/SourceManager.cpp:967
if (isOffsetInFileID(FileID::get(-int(MiddleIndex) - 2), SLocOffset)) {
FileID Res = FileID::get(-int(MiddleIndex) - 2);
----------------
kadircet wrote:
> my comments above for `isOffsetnLocalFileID` applies to here as well, in case
> you decide to move them into a separate patch.
This case `getFileIDLoaded()` did not show up in any traces. It also doesn't
have the same FIXME (though that doesn't really matter). As such, I'm more
inclined to "let sleeping dogs lie."
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80681/new/
https://reviews.llvm.org/D80681
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
