sammccall added a comment. I'm afraid I don't really understand how this fix works, so my questions might be silly. Thanks for fixing things!
================ Comment at: clang-tools-extra/clangd/CMakeLists.txt:105 + +clang_target_link_libraries(clangDaemon + PRIVATE ---------------- This has split our link dependencies in two, and I'm not really sure why (and so am likely to put future dependencies in the wrong place). Can *all* the link dependencies be moved to the clang_target_link_libraries section? ((Even if this addresses a problem only seen with clang libs, I'd rather have everything in one place) ================ Comment at: clang-tools-extra/clangd/unittests/CMakeLists.txt:123 clangTidy - LLVMSupport LLVMTestingSupport ---------------- why this change? We do depend directly on LLVMSupport, and I'd prefer that to remain explicit rather than pick it up transitively. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81967/new/ https://reviews.llvm.org/D81967 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
