aaron.ballman added a comment. In D81953#2096635 <https://reviews.llvm.org/D81953#2096635>, @njames93 wrote:
> In D81953#2096388 <https://reviews.llvm.org/D81953#2096388>, @aaron.ballman > wrote: > > > LGTM unless @jroelofs has a reason why the code was originally written that > > way, but can you add test coverage for it? > > > How would you suggest I add test coverage for this, afaik llvm-lit doesn't > seem to handle checking specific exit codes, only whether is was 0 or not. > There are already test cases for a non-zero exit code with > `-warnings-as-errors`. If lit doesn't provide a way to do this, I don't insist. I was thinking you'd have a way to use the lit shell to compare against the return value since it had the ability to test against nonzero or not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81953/new/ https://reviews.llvm.org/D81953 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
