baloghadamsoftware added a comment.

In D81718#2096540 <https://reviews.llvm.org/D81718#2096540>, @NoQ wrote:

> In D81718#2095965 <https://reviews.llvm.org/D81718#2095965>, 
> @baloghadamsoftware wrote:
>
> > Your test case unfortunately does not test what you want, because raw 
> > pointers are not supported yet
>
>
> It tests exactly what i want: the correctness of your code in //this very 
> patch// that was written to handle //this very case// for which you never 
> even bothered figuring out the correct solution but you already wrote //a 
> large amount of code// (including some code in this patch) //with zero test 
> coverage// to demonstrate correctness of your solution.


Did you read my comment? These functions are //not called by all// by your 
tests!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81718/new/

https://reviews.llvm.org/D81718



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to