dblaikie added a comment. In D81732#2094735 <https://reviews.llvm.org/D81732#2094735>, @mboehme wrote:
> In D81732#2093260 <https://reviews.llvm.org/D81732#2093260>, @dblaikie wrote: > > > Test case(s)? > > > Is there anything specific you have in mind? > > This change should be behavior-preserving in the case where > -fmodules-local-submodule-visibility isn't set, as evidenced by the existing > tests, which continue to pass. > > This change is a small step towards making > -fmodules-local-submodule-visibility work for Objective-C, but unfortunately > we're still a long way off from being able to turn this flag on; activating > it for existing tests still causes them to fail because parts of AST are > still using Decl::isUnconditionallyVisible() instead of Sema::isVisible(), > and that's unfortunately harder to fix. Maybe take the smallest/simplest example using -fmodules-local-submodule-visibility and Objective-C and add all Sema::isVisible needed to make that work & include that as a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81732/new/ https://reviews.llvm.org/D81732 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
