MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land.
Looks great! Please give other reviews a day or two to respond in case they have comments. ================ Comment at: clang/test/Driver/program-path-priority.c:22 +/// No gccs at all, nothing is found +// RUN: env "PATH=" %t/clang -### -target notreal-none-elf %s 2>&1 \ +// RUN: | FileCheck --check-prefix=NO_NOTREAL_GCC %s ---------------- Nit: this may be the preference of some reviewers, but they tend to favor `| \` in the end of the last line. `|` makes it clear that it has a continuation line (and if you type the first line with `|`, your shell will wait for the next line) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new/ https://reviews.llvm.org/D79842 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
