aaron.ballman added a comment.

Changes generally LGTM, but this is not my area of expertise.



================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2622
     Guard->setThreadLocal(true);
+    Guard->setThreadLocalMode(CGM.GetDefaultLLVMTLSModel());
 
----------------
Do we need a similar change in `MicrosoftCXXABI::EmitGuardedInit()`? I notice 
it sets thread local to true but does not set the thread local mode.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81543/new/

https://reviews.llvm.org/D81543



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to