aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
In D81786#2091781 <https://reviews.llvm.org/D81786#2091781>, @riccibruno wrote: > Summarising a quick discussion with @lebedev.ri on IRC yesterday: this is > not necessarily the best way to test the serialization of AST nodes, in that > we could instead perform some kind of structural equivalence test. However > this approach has the huge advantage of being simply a matter of 1. Adding a > few run lines to each `ast-dump-*`, and 2. running this script on the test. > (see rG6a79f5aa5dbc2528444b4dfb92bb68039c5a32e9 > <https://reviews.llvm.org/rG6a79f5aa5dbc2528444b4dfb92bb68039c5a32e9> for an > example of what the output looks like) > > What I'd like to do (and get approval for, since I don't think it is > worthwhile to individually put each changed test for review) is go over each > AST dump tests (ie: each `ast-dump-*`) and do the above (possibly splitting > some tests intro multiple files if they are too big). > > Edit: Excluding AST dump tests which are about the serialization itself, or > modules. This seems reasonable to me. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81786/new/ https://reviews.llvm.org/D81786 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
