NoQ added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:233 + return false; + if (MethodDec->getDeclName().isIdentifier()) { + return ResetMethods.count(MethodDec->getName().lower()); ---------------- vsavchenko wrote: > I'm not sure about it myself, but can `DeclName` be `isEmpty()`? If yes, it > is a potential null-pointer dereference. Again, I don't know it for a fact, > but I think it should be checked. NOTE: 👏 Call 👏 Description 👏 Map 👏 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81315/new/ https://reviews.llvm.org/D81315 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits