saugustine created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. saugustine added reviewers: jyknight, echristo. saugustine added a comment.
For post-commit review. ROCm.h had been getting the declarations for various data structures by being #included next to them, rather than #includeing them itself. This change fixes that by explicitly including the appropriate headers. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81432 Files: clang/lib/Driver/ToolChains/ROCm.h Index: clang/lib/Driver/ToolChains/ROCm.h =================================================================== --- clang/lib/Driver/ToolChains/ROCm.h +++ clang/lib/Driver/ToolChains/ROCm.h @@ -10,9 +10,14 @@ #define LLVM_CLANG_LIB_DRIVER_TOOLCHAINS_ROCM_H #include "clang/Basic/Cuda.h" +#include "clang/Basic/LLVM.h" +#include "clang/Driver/Driver.h" #include "clang/Driver/Options.h" #include "llvm/ADT/SmallSet.h" #include "llvm/ADT/SmallString.h" +#include "llvm/ADT/StringMap.h" +#include "llvm/ADT/Triple.h" +#include "llvm/Option/ArgList.h" namespace clang { namespace driver {
Index: clang/lib/Driver/ToolChains/ROCm.h =================================================================== --- clang/lib/Driver/ToolChains/ROCm.h +++ clang/lib/Driver/ToolChains/ROCm.h @@ -10,9 +10,14 @@ #define LLVM_CLANG_LIB_DRIVER_TOOLCHAINS_ROCM_H #include "clang/Basic/Cuda.h" +#include "clang/Basic/LLVM.h" +#include "clang/Driver/Driver.h" #include "clang/Driver/Options.h" #include "llvm/ADT/SmallSet.h" #include "llvm/ADT/SmallString.h" +#include "llvm/ADT/StringMap.h" +#include "llvm/ADT/Triple.h" +#include "llvm/Option/ArgList.h" namespace clang { namespace driver {
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits