saiislam marked 7 inline comments as done. saiislam added inline comments.
================ Comment at: clang/include/clang/Basic/TargetInfo.h:202 + const unsigned *GridValues; + const uint64_t *LongGridValues; ---------------- jdoerfert wrote: > I would recommend adding a descriptive comment, even though that seems not to > be the norm here. > Why do we split these into "normal" and "long" grid values again? > > `= nullptr` and an assert in the getters? Realized no practical use of separate long values. Folded into regular enum and arrays. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80917/new/ https://reviews.llvm.org/D80917 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
