riccibruno marked an inline comment as done.
riccibruno added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2031-2033
+  "%select{|member |static member }0%2"
+  "%select{| of %3| of struct %4| of union %4| of class %4"
+  "| of structured binding %3}1">, InGroup<Unsequenced>;
----------------
rsmith wrote:
> I wonder if we could just print out a simple access path here (eg `x.a[3]`). 
> `APValue` has support for representing and pretty-printing such things 
> already, and you could try passing arbitrary lvalue expressions to the 
> constant evaluator to try to form them rather than special-casing a few 
> things in `getMemoryLocationImpl`.
Ah yes perhaps this can work. I will take a look at that. Thanks for the 
pointer!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57660/new/

https://reviews.llvm.org/D57660



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D57660: [... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D576... Bruno Ricci via Phabricator via cfe-commits

Reply via email to