hokein added inline comments.
================
Comment at: clang/lib/Sema/SemaExprCXX.cpp:8310
+ // to RecoveryExpr.
+ // FIXME: we lose source locations for RecoveryExpr, as TypoExpr doesn't
+ // track source locations.
----------------
sammccall wrote:
> This seems reasonably straightforward to fix - there shouldn't be a lot of
> TypoExprs so we can just add a member. Worth doing I think.
yeah, agree. Will address it in a followup.
================
Comment at: clang/lib/Sema/SemaExprCXX.cpp:8314
+ using Base = TreeTransform<TyposReplace>;
+ TyposReplace(Sema &SemaRef) : Base(SemaRef) {}
+ ExprResult TransformTypoExpr(TypoExpr *E) {
----------------
sammccall wrote:
> Can't you just write this as `: TreeTransform(SemaRef) {}`, and drop the
> using?
yes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80733/new/
https://reviews.llvm.org/D80733
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
