curdeius accepted this revision.
curdeius added a comment.
This revision is now accepted and ready to land.
LGTM.
It may be silly, but the fact that this code runs over all the tokens makes me
think: do we have any performance-related non-regression tests for clang-format?
================
Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:1093
+
+TEST_F(NamespaceEndCommentsFixerTest, IgnoreUnbalanced) {
+ EXPECT_EQ("namespace A {\n"
----------------
Nit: You may add PR46130 in the test name *if* this is what is done usually (I
see it in the test above).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80830/new/
https://reviews.llvm.org/D80830
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
