rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

>> I'm actually surprised it doesn't.  I can't imagine why someone enabling 
>> fast math would want contraction to be disabled.
> 
> Just to be clear the clang driver does the right thing.
>  If you run `clang -ffast-math` the CC1 invocation has both `-ffast-math` and 
> `-ffp-contract=fast` (and other options as well)
> 
> Here specifically I'm just considering the behavior of `clang -cc1 
> -ffast-math`.

Okay.  It is probably best for testing purposes if flags like this stay as 
close as possible to their driver behavior.  The driver can just canonicalize 
different spellings down to the interface that -cc1 wants.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80315/new/

https://reviews.llvm.org/D80315



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to