sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:4658
bool IgnoreConstraints) {
+ // FIXME: continue the following steps if the type is known.
+ if (Init->containsErrors())
----------------
it's not clear to me what "if the type is known" means precisely.
If it's just a matter of checking some condition and continuing, presumably
we'd do that already. as is, the FIXME doesn't seem actionable.
================
Comment at: clang/test/AST/ast-dump-invalid-auto-return-funcs.cpp:3
+
+// CHECK: FunctionDecl {{.*}} s1 'auto ()'
+auto s1(); // valid
----------------
maybe add a comment/FIXME about why we're finding int as the return type?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80221/new/
https://reviews.llvm.org/D80221
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
