scott.linder accepted this revision.
scott.linder added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
================
Comment at: llvm/cmake/modules/AddLLVM.cmake:1916
endif()
- if(EXISTS "${path}/.svn")
- set(svn_files
----------------
Nit: can this be in a separate commit (no need for another review), or at least
be explicitly called out in the commit message of this patch?
================
Comment at: llvm/include/llvm/Support/CMakeLists.txt:12
+ if (NOT llvm_vc)
+ set(fake_version_inc "${CMAKE_CURRENT_BINARY_DIR}/__FakeVCSRevision.h")
+ endif()
----------------
Nit: can you add a comment indicating this is never expected to exist, and is
just used to force regeneration for the read-only case? Otherwise it may not be
obvious to someone reading what the trick here is.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79400/new/
https://reviews.llvm.org/D79400
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
