baloghadamsoftware marked an inline comment as done.
baloghadamsoftware added a comment.

> I will check tomorrow whether we could remove `DeclRegion` without too much 
> code duplication.

It turns out that `DeclRegion` is used in 7 different checkers plus in 
`BugReporterVisitor`s. One typical use case is to get a name for the region (by 
getting the `Decl` and trying to cast it to `NamedDecl`), but there are also 
others as well. For now I suggest to keep it to avoid code duplication.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80522/new/

https://reviews.llvm.org/D80522



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to