sconstab added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:200
+ if (!Args.hasArg(options::OPT_mno_lvi_cfi)) {
+ Features.push_back("+lvi-cfi");
+ LVIOpt = options::OPT_mlvi_cfi;
----------------
Would it be better to add `FeatureLVIControlFlowIntegrity` as a dependency for
`FeatureSpeculativeExecutionSideEffectSuppression` in
`llvm/lib/Target/X86/X86.td`?
================
Comment at:
llvm/lib/Target/X86/X86SpeculativeExecutionSideEffectSuppression.cpp:90
+ const X86Subtarget &Subtarget = MF.getSubtarget<X86Subtarget>();
+ if (!Subtarget.useSpeculativeExecutionSideEffectSuppression() &&
+ !EnableSpeculativeExecutionSideEffectSuppression)
----------------
Is it really necessary to have the target feature and the CLI flag? If SESES is
required for, say, a *.ll file, then `+seses` can always be added as a target
feature.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79910/new/
https://reviews.llvm.org/D79910
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
