NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land.
I absolutely buy this. If somebody is to ever implement another `ExprEngine`, dealing with the lack of a convenient virtual interface will definitely be a negligible problem for them. ================ Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:650 + +protected: + /// evalBind - Handle the semantics of binding a value to a specific location. ---------------- What's the point of `protected` if we don't expect anybody to ever inherit from us? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80548/new/ https://reviews.llvm.org/D80548 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
