hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added a comment.
LGTM with minor comment. ================ Comment at: clang/test/Driver/aix-ld.c:8 -// RUN: --sysroot %S/Inputs/aix_ppc_tree \ -// RUN: | FileCheck --check-prefix=CHECK-LD32 %s // CHECK-LD32-NOT: warning: ---------------- The two-space indent for continuations on a pipeline or similar boundary was intentional. We're only somewhat okay here because the non-terminal commands are all multiline deep indentation. I think we should retain the two-space indent. ================ Comment at: clang/test/Driver/aix-ld.c:54 -// Check powerpc-ibm-aix7.1.0.0, 64-bit. POSIX thread alias. -// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \ -// RUN: -pthreads \ -// RUN: -target powerpc64-ibm-aix7.1.0.0 \ -// RUN: --sysroot %S/Inputs/aix_ppc_tree \ -// RUN: | FileCheck --check-prefix=CHECK-LD64-PTHREAD %s +// Check powerpc64-ibm-aix7.1.0.0, 64-bit. POSIX thread alias. +// RUN: %clang -no-canonical-prefixes %s -### 2>&1 \ ---------------- Good catch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80532/new/ https://reviews.llvm.org/D80532 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
