aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
Aside from a minor nit with the matcher, this LGTM! ================ Comment at: clang-tools-extra/clang-tidy/altera/StructPackAlignCheck.cpp:50-53 + // Do not trigger on template instantiations because the packing and + // alignment requirements are unknown. + if (Struct->isTemplated()) + return; ---------------- I think this should be hoisted into the AST matcher using `unless(isTemplateInstantiation())`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66564/new/ https://reviews.llvm.org/D66564 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
