NeHuang added inline comments.
================ Comment at: clang/lib/Basic/Targets/PPC.cpp:339 if (!(ArchDefs & ArchDefinePwr9) && (ArchDefs & ArchDefinePpcgr) && llvm::find(FeaturesVec, "+float128") != FeaturesVec.end()) { ---------------- I think we also need to check for `ArchDefinePwr10` and `ArchDefineFuture` based on the comment "// We have __float128 on PPC but not power 9 and above." `!(ArchDefs & ArchDefinePwr9)` -> `!(ArchDefs & (ArchDefinePwr9 | ArchDefinePwr10 | ArchDefineFuture))` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/ https://reviews.llvm.org/D80020 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits