NoQ added a comment. In D79704#2038257 <https://reviews.llvm.org/D79704#2038257>, @Szelethus wrote:
> In D79704#2037100 <https://reviews.llvm.org/D79704#2037100>, @NoQ wrote: > > > > The code changes make me feel like we're doing a lot of chore (and make > > > it super easy to forget checking for parameters explicitly). > > > > I wouldn't mind having a common base class for these regions. `DeclRegion` > > should probably be dropped in this case, in order to avoid dealing with > > multiple inheritance. And it's definitely the one that needs to be dropped > > because it currently does nothing except "inheritance for code reuse": > > there are basically no other common properties between its sub-classes than > > the accidental code reuse in its methods. > > > Totally. Something like a `VarRegionBase` but with a more clever name. We can even call it `VarRegion` and have sub-classes be `ParamVarRegion` and `NonParamVarRegion` or something like that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79704/new/ https://reviews.llvm.org/D79704 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
