Xiangling_L added inline comments.
================ Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1300 OPT_maix_struct_return, OPT_msvr4_struct_return)) { + // TODO: We might want to consider enabling these options on AIX in the + // future. ---------------- Since we disable them in FE, should we remove the one in driver? ================ Comment at: clang/test/Frontend/aix-unsupported.c:10 +// RUN: -c %s 2>&1 | FileCheck %s +// CHECK: unsupported option ---------------- One thing I am not so sure about is that for these two options `-maix-struct-return`, `-msvr4-struct-return`, do we need to update the `ClangCommandLineReference.rst` since we emit diags `unsupported option '-maix-struct-return' for target 'powerpc-unknown-aix'` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79035/new/ https://reviews.llvm.org/D79035 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits