tlively marked an inline comment as done. tlively added inline comments.
================ Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:147 +TARGET_BUILTIN(__builtin_wasm_pmin_f64x2, "V2dV2dV2d", "nc", "simd128") +TARGET_BUILTIN(__builtin_wasm_pmax_f64x2, "V2dV2dV2d", "nc", "simd128") ---------------- aheejin wrote: > For unimplemented instructions, when do we use `simd128` and when > `unimplemented-simd128`? `unimplemented-simd128` is better when the V8 implementation is expected to lag significantly behind the toolchain implementation, but in this case the instructions are being implemented in V8 in parallel. Using `simd128` makes it much easier for users to experiment with. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79742/new/ https://reviews.llvm.org/D79742 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
